FIX: Unassign buttons on the activity/assigned page don't work #559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've noticed problems when unassigning a topic on the
activity/assigned
page using this button:One of two incorrect things happens when pressing this button:
That happens because this handler for all buttons somehow always use the same state - the state of the first topic on the page:
discourse-assign/assets/javascripts/discourse/components/assign-actions-dropdown.js
Lines 55 to 68 in f2906e0
There seem to be some nuances in select-kit and I'm not sure whether this should be qualified as a bug in select-kit. However, I've noticed that in other cases when we use
DropdownSelectBoxComponent
we use theonChange
handler rather thanonSelect
.So I switched this code to using
onChange
and that resolved the issue, theonChange
handler has access to correct state.Tests will be in a follow-up.